This repository was archived by the owner on Jul 8, 2025. It is now read-only.
feat: Added SpawnReasons and RoleSpawnFlags to CustomRole and some item/ammo fixes#20
Closed
louis1706 wants to merge 14 commits intoExSLMod-Team:devfrom
Bonjemus:dev
Closed
feat: Added SpawnReasons and RoleSpawnFlags to CustomRole and some item/ammo fixes#20louis1706 wants to merge 14 commits intoExSLMod-Team:devfrom Bonjemus:dev
louis1706 wants to merge 14 commits intoExSLMod-Team:devfrom
Bonjemus:dev
Conversation
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Read title.
What is the current behavior? (You can also link to an open issue here)
Currently CustomRole always uses ForceClass as a SpawnReason and doesn't allow devs to specify RoleSpawnFlags.
Additionally, CustomRole behaviours when it comes to ammo and items was inconsistent so I also fixed it.
What is the new behavior? (if this is a feature change)
Read title.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes :
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other